Rough port of the fix for the Z-TERM3 thermostat from open-zwave 1.6 branch #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have resolved the two remaining issues and squashed the commits. As far as I can see, this is a correct port of the 1.6 branch fix, and it works fine on my Jeedom instance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete description of the problem and solution here: OpenZWave/open-zwave#2458
This is a port of the fix to openzwave branch 1.4
It works as far as I can see (you will need to use "Regenerer la detection du noeud" if the thermostat module is already added).
There are at least two issues which would need a look from someone more knowledgeable about openzwave than I am: an issue with ValueIDs (their management is very different in 1.6), and an issue with the node Version() check. I solved both in a brutal way which may cause problems.