Allow yield to logger methods & bail early on no-op messages
#6315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Standard loggers in Ruby mostly `yield` their messages (this is the default behavior of Ruby's own logger.) Or if there is a block then the message is the topic, a colon is automatically added, and the message is shipped with the topic. Jekyll should conform to this behavior so that it's logger can be passed to libraries that expect this standard behavior.
```ruby
[1] pry(main)> Jekyll.logger.info("Just so you know") # => Just so you know
[2] pry(main)> Jekyll.logger.info("Just so you know", "this is a message") # => Just so you know this is a message
[3] pry(main)> Jekyll.logger.info("Just so you know") { "this is a message" }
# => Just so you know: this is a message
```
Signed-off-by: Parker Moore <[email protected]>
parkr
force-pushed
the
envygeeks-allow-yield
branch
from
f2d0a06 to
9737908
Compare
DirtyF
approved these changes
Aug 18, 2017
|
Maybe @envygeeks wants to do a proper benchmark to see how this affect its build performance? With Jekyll's Before: real 2m24.422s
user 1m56.664s
sys 0m11.537sAfter: |
|
Whoa, who knew logging could be so expensive! I just remembered that we can push this even further by setting the log level to On my MBP: |
|
@jekyllbot: merge +minor |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This subsumes #6306 and fixes the bugs with that PR.
It also bails early for
debug,info,warn, anderrorif the logger's log level is higher than the message's log level. In this case the logging writer will skip it, so it's best to skip it here. It reduces the number of strings we create and greatly reduces the size of themessagesarray. This fixes #6313.