Remove Config.required_fields
#172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jeregrine assigning you to review this one. You're the author of the original commit. Perhaps you can shine some light on this mystery param? |
This parameter on `Config` has its origins in work done to parse `"includes"` shown here: c794148. As far as I can tell this parameter is both undocumented and unused. It should be completely safe to remove.
jherdman
force-pushed
the
remove-required-fields
branch
from
47ff988 to
87a9744
Compare
|
@jeregrine have you had any time to mull this over? |
jeregrine
approved these changes
Feb 8, 2019
|
Sorry for delay. Looks good. |
doomspork
approved these changes
Feb 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This parameter on
Confighas its origins in work done to parse"includes"shown here: c794148.As far as I can tell this parameter is both undocumented and unused. It
should be completely safe to remove.