Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Narrow further, and don't use microarch #30

Merged
merged 27 commits into from
Nov 1, 2023
Merged

Narrow further, and don't use microarch #30

merged 27 commits into from
Nov 1, 2023

Conversation

jerinphilip
Copy link
Owner

@jerinphilip jerinphilip commented Oct 31, 2023

This is some cursed debugging on GitHub CI trying to smoke out illegal instruction core dumped. Does not happen on my system, and ends up happening on CI. Happens intermittently. Did some guesswork attempts trying to improve the situation, did not pan out. So here we are. In the process I'm parallely discovering lldb, gdb and other weird places that I have no one but myself to blame for getting me into.

Hey, there's possibly light at the end of the tunnel.

* thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_INSTRUCTION (code=EXC_I386_INVOP, subcode=0x0)
    frame #0: 0x00000001002c4626 slimt-cli`slimt::Tensor slimt::qmm::detail::dot<(slimt::qmm::detail::Provider)3>(x=0x00007ff7bfefbcc0, W=0x0000621000007f88, a_quant=11.9759073, b_quant=72.2858505, name="rnn_o") at Gemmology.inl.cc:300:42
   297 	  float a_alpha = kInt8Maxf / a_quant;
   298 	  float b_alpha = kInt8Maxf / b_quant;
   299 	
-> 300 	  float bias_unquant_multiplier = (-1.0F * (a_alpha * b_alpha)) / kInt8Maxf;
    	                                         ^
   301 	  auto prepare_bias_callback =
   302 	      gemmology::callbacks::UnquantizeAndAddBiasAndWrite(
   303 	          bias_unquant_multiplier, bias.data<float>(),  //

@jerinphilip jerinphilip changed the title Don't use microarch Narrow further, and don't use microarch Nov 1, 2023
@jerinphilip jerinphilip marked this pull request as ready for review November 1, 2023 00:11
@jerinphilip jerinphilip merged commit ce86a26 into main Nov 1, 2023
@jerinphilip jerinphilip deleted the no-microarch branch November 1, 2023 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant