Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JNI bindings along with a package #49

Merged
merged 29 commits into from
Apr 11, 2024
Merged

Add JNI bindings along with a package #49

merged 29 commits into from
Apr 11, 2024

Conversation

jerinphilip
Copy link
Owner

@jerinphilip jerinphilip commented Mar 17, 2024

Add JNI bindings for use via Java (intended for an offline translation android application). The cache which is meant to speed up translations (especially while typing), which was not working previously is configured to work now.

MacOS CI requires some fixing since SentencePiece 0.2.0 (via brew) breaks some assumptions here. Using internal sentencepiece for time-being as a stopgap solution.


Attempting to use the models in an android-application. Hypothesis is it is simpler to export a .jar file from here following native-library requirements (preferably from the current android build).

Maybe I can use cmake voodoo to build this jar and ship as an artifact?

Once built for a armv8a ABI, should be portable across a lot of devices (at least my device).

I really only care about android-armv8a at the moment, wider JNI can be applied if and when required.

Works. Tecno Pova 3 (LF7)

Don't know java, so let's compile some guides:

  1. https://stackoverflow.com/questions/8135282/entity-class-string-vs-liststring
  2. https://stackoverflow.com/questions/3226282/are-there-best-practices-for-java-package-organization

@jerinphilip jerinphilip marked this pull request as ready for review March 18, 2024 14:50
@jerinphilip jerinphilip changed the title JNI Add JNI bindings along with a package Apr 11, 2024
@jerinphilip jerinphilip merged commit 9f0b1a2 into main Apr 11, 2024
8 checks passed
@jerinphilip jerinphilip deleted the jni branch April 11, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant