-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JNI bindings along with a package #49
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add JNI bindings for use via Java (intended for an offline translation android application). The cache which is meant to speed up translations (especially while typing), which was not working previously is configured to work now.
MacOS CI requires some fixing since SentencePiece 0.2.0 (via brew) breaks some assumptions here. Using internal sentencepiece for time-being as a stopgap solution.
Attempting to use the models in an android-application. Hypothesis is it is simpler to export a
.jar
file from here following native-library requirements (preferably from the current android build).Maybe I can use cmake voodoo to build this jar and ship as an artifact?
Once built for a armv8a ABI, should be portable across a lot of devices (at least my device).
I really only care about android-armv8a at the moment, wider JNI can be applied if and when required.
Works. Tecno Pova 3 (LF7)
Don't know java, so let's compile some guides: