Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asciidoctor images #6538

Closed
docsAsCode opened this issue Jul 16, 2020 · 8 comments
Closed

asciidoctor images #6538

docsAsCode opened this issue Jul 16, 2020 · 8 comments

Comments

@docsAsCode
Copy link

In asciidoc (or asciidoctor) format we can use two kind of images : inline or block.
inline image syntax is :

Click image:icons/play.png[Play, title="Play"] to get the party started.

block image syntax is (double :) :

image::sunset.jpg[Sunset]

block image can be considered as figure in other language (rst, docbook).

In pandoc 2.10 only inline image is generated. Like you generate figure in rst or docbook, can you generate block image in asciidoc ?

Thx

@mb21
Copy link
Collaborator

mb21 commented Jul 16, 2020

hm... and how should we decide whether to render inline or block?

@jgm
Copy link
Owner

jgm commented Jul 16, 2020

We can do what we do in other formats.
If the image is the only element in a Para, and has a title beginning with the prefix fig:, then we render it as a figure, stripping the prefix from the title.

@kukimik
Copy link

kukimik commented Sep 4, 2020

Hello! I'd be happy to work on this issue. The change to make looks rather easy and isolated, but I'm new to pandoc and want to understand what's going on here, so this may take me a while.

@tarleb
Copy link
Collaborator

tarleb commented Sep 4, 2020

Great! Don't hesitate to reach out if you have questions or run in to problems.

@argent0
Copy link
Contributor

argent0 commented Sep 8, 2020

@kukimik I made the pull-request before seeing your claim. Sorry

@kukimik
Copy link

kukimik commented Sep 9, 2020

@argent0 That's ok. I'll find myself another issue to work on. 😉

@docsAsCode
Copy link
Author

Hello,

Happy to see the progress for my issue.

I forget to say block images support horizontal alignement:

image::sunset.jpg[Sunset,align=center]

@tarleb
Copy link
Collaborator

tarleb commented Sep 9, 2020

It may be better to raise this as a new issue once this one is closed.

@jgm jgm closed this as completed in ba9bede Sep 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants