Add hotkeys to enable (F1) / disable (F2) server on all backends #4
Conversation
|
The code looks good. I'll try to take it for a spin on some of my haproxies this week and get this merged by Friday, @tili41 |
|
I finally got around to testing this! It works like a charm. I did notice that the bin/hatop mode changed from 0755 (executable) to 0644 (non-executable); that would need to be undone before merge. I also would like to change the labels to:
But, since it's been almost three months between PR and review, I'll go ahead and handle those changes myself. Thanks again! |
| 'F4=W-RESET ' | ||
| 'F5=W-10 F6=W-1 F7=W+1 F8=W+10 ' | ||
| 'F9=ENABLE F10=DISABLE', | ||
| 'F9=ENABLE_ONE_BACK F10=DISABLE_ONE_BACK', |
There was a problem hiding this comment.
Let's relabel these "ENABLE (HERE)" and "DISABLE (HERE)"
| @@ -1162,9 +1165,10 @@ class Screen: | |||
| self.addstr(ypos, 1, 'HOTKEYS:', | |||
| curses.A_BOLD | curses.A_REVERSE) | |||
| self.addstr(ypos, 11, | |||
| 'F1=ENABLE_ALL_BACK F2=DISABLE_ALL_BACK ' | |||
There was a problem hiding this comment.
Let's relabel these "ENABLE" and "DISABLE", since this is the default (and usually correct) behavior.
|
This was merged (after some rework) in #5. |
Useful if you have servers (based on hostname) in several different backends. Maybe a bit too specific to use hotkeys...