Fixed bug around non anime/manga search #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error message screenshot:
The app has a special logic / optimization for short search terms. When the search term is shorter than 4 characters in length, the app changes the options sent to the Typesense API to improve search results.
In case of all non anime/manga endpoints which allow searching through the search index there is a bug when you try to search with short search terms (shorter than 4 in length) the api returns a 500 error. This is caused by the before mentioned logic being only specific to the anime/manga endpoints.
This PR addresses this issue by adding a default value for the "sort_by" option being sent to Typesense API.