Container image release fixes #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are building multi arch images in the github action. On the packages page of the repo, for each version you see "No description" provided, however the github action already adds that label to the container image. See here: https://github.com/jikan-me/jikan-rest/pkgs/container/jikan-rest/141371328?tag=sha-56f4783 In case of multi arch images the manifest should contain these OCI standard labels in the "annotations" section. This PR adds the defined labels as annotations when creating the image manifest.
pushrbx
changed the title
irfan-dahir
approved these changes
Oct 27, 2023
|
@irfan-dahir I will need to rollback the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are building multi arch images in the github action. On the packages page of the repo, for each version you see "No description" provided, however the github action already adds that label to the container image. See here: https://github.com/jikan-me/jikan-rest/pkgs/container/jikan-rest/141371328?tag=sha-56f4783
In case of multi arch images the manifest should contain these OCI standard labels in the "annotations" section. This PR adds the defined labels as annotations when creating the image manifest.
Additional changes: