Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include other participants' public nonces in reference tests #14

Closed
nickfarrow opened this issue May 10, 2022 · 2 comments
Closed

Include other participants' public nonces in reference tests #14

nickfarrow opened this issue May 10, 2022 · 2 comments

Comments

@nickfarrow
Copy link

Some implementations of MuSig will be easier to test if the reference contains the other party's public nonces, as opposed to the nonces having already been aggregated. If you initialize signing sessions with [nonce1, nonce2, ... ] rather than a pre-aggregated aggnonce,

The other two participants' public nonces could be aggregated within the tests themselves, or included in a comment above aggnonce = .... Or in a separate basic test for nonce_agg(). This would make both pre-aggregated and nonce-list input designs easy to test.

@jonasnick
Copy link
Owner

Good point. The public nonces are added to the test vectors in PR #9 (e.g. here).

@real-or-random
Copy link
Collaborator

Solved by #9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants