From 0d958d6ed80dca7a44760232448d9c435ccde682 Mon Sep 17 00:00:00 2001 From: Jordan Baird Date: Wed, 22 Jan 2025 08:56:30 -0700 Subject: [PATCH] Fix possible retain cycle --- Ice/UI/IceBar/IceBar.swift | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Ice/UI/IceBar/IceBar.swift b/Ice/UI/IceBar/IceBar.swift index c3004cc..40c6898 100644 --- a/Ice/UI/IceBar/IceBar.swift +++ b/Ice/UI/IceBar/IceBar.swift @@ -55,8 +55,7 @@ final class IceBarPanel: NSPanel { .store(in: &c) if - let appState, - let section = appState.menuBarManager.section(withName: .hidden), + let section = appState?.menuBarManager.section(withName: .hidden), let window = section.controlItem.window { window.publisher(for: \.frame) @@ -64,6 +63,7 @@ final class IceBarPanel: NSPanel { .sink { [weak self, weak window] _ in guard let self, + let appState, // Only continue if the menu bar is automatically hidden, as Ice // can't currently display its menu bar items. appState.menuBarManager.isMenuBarHiddenBySystemUserDefaults,