Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Function naming incorrect/missing #49

Open
pinkynrg opened this issue Aug 7, 2017 · 2 comments
Open

Function naming incorrect/missing #49

pinkynrg opened this issue Aug 7, 2017 · 2 comments

Comments

@pinkynrg
Copy link

pinkynrg commented Aug 7, 2017 •
edited
Loading

I noticed that a few functions in functional.rb have not the same name as the Atoms in the yml file, such as:

  • functional.rb => tan100, derived_unit.rb => 100tan
  • functional.rb => ph, derived_unit.rb => pH

Also there are some ":function_code"s that has not been implemented in functional.rb such as:

  • hpM
  • hpQ
  • sqrt
@pinkynrg pinkynrg changed the title Function naming incorrect Function naming incorrect/missing Aug 7, 2017
@phlegx
Copy link
Contributor

phlegx commented Aug 8, 2017

Hi @pinkynrg can you implement the functions and make a PR please?

@pinkynrg
Copy link
Author

pinkynrg commented Aug 8, 2017

I'm try my best to google the correct formulas.

@pinkynrg pinkynrg mentioned this issue Aug 8, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@phlegx @pinkynrg