This repository has been archived by the owner on May 4, 2018. It is now read-only.
Implement detached child processes for unix and windows #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ld process should spawn detached from its parent.
|
PTAL at nodejs/node-v0.x-archive#3344, I would appreciate your comments, especially around killpg(). |
|
Is this pull request going to be superseded by https://github.com/AvianFlu/libuv/compare/detached2? That one no longer has a force-close of std streams, or a second fork() -- both of which are IMHO good differences. It still does not allow to call killpg() on UNIX. |
|
Yes, this patch is defunct. I'll close it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cleaned-up version of #322 with some important bug fixes for unix. Now, on both unix and Windows, processes will detach properly, will not maintain connections to any prior
stdiohandles, and run as the head of a new process group.