Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I thought node version 4+ is supported #579

Closed
albacoretuna opened this issue May 12, 2018 · 5 comments
Closed

I thought node version 4+ is supported #579

albacoretuna opened this issue May 12, 2018 · 5 comments

Comments

@albacoretuna
Copy link

Hello, thanks for the nice library :)
I remember in the ES6 discussions, people mentioned node version 4.9+ for this library. But seems that it actually needs node 6+ because of the spread operators.

Should that be mentioned in Readme? I'm just hoping it saves some time for someone who needs to support node 4.

@RyanZim
Copy link
Collaborator

RyanZim commented May 12, 2018

fs-extra v6 dropped Node 4 support since it's EOL: https://github.com/jprichardson/node-fs-extra/blob/master/CHANGELOG.md#600--2018-05-01

@albacoretuna
Copy link
Author

Thanks.

Would it help to mention the node version requirement in Readme?

Otherwise please feel free to close this.

@RyanZim
Copy link
Collaborator

RyanZim commented May 12, 2018

I personally hate having to remember to update the README; people can look at the .travis.yml and figure it out.

@RyanZim RyanZim closed this as completed May 12, 2018
@JPeer264
Copy link
Collaborator

@RyanZim what about having specified engines in the package.json? I think that would help more people who are not familiar with a .travis.yml.
https://docs.npmjs.com/files/package.json#engines

@jprichardson
Copy link
Owner

@JPeer264 great idea. Would you submit a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants