Skip to content
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.

rewriteBase #2539

Closed
wants to merge 1 commit into from
Closed

rewriteBase #2539

wants to merge 1 commit into from

Conversation

ArakTaiRoth
Copy link

Added an option, rewriteBase, that can enable (by default) or disable the rewriting of the base element or urls. This may be needed by groups that are already rewriting their base element or urls for some other purpose.

@johnbender
Copy link
Contributor

As a side note to anyone viewing the single commit diff adding ?w=1 makes it much easier to review 👍

@johnbender
Copy link
Contributor

@ArakTaiRoth,

This is a good idea, but I'm worried that the base variable, and subsequently, $.mobile.base are two very different types in the patch depending on the rewriteBase attribute. That is, if it's enabled base is a singleton object and if it's not base is a string. It seems like this will likely be a source of bugs down the road.

I still need to take a closer look to see what's involved, but the idea is a good one and something I think we should support.

@ArakTaiRoth
Copy link
Author

If you have any suggestions on a different path you would like to go, I would be happy to look into them for you and see what I can implement.

@ArakTaiRoth
Copy link
Author

I'll be honest, this was done really quickly as it was a required change for the company I work for in order to be able to use jQuery Mobile, so I didn't do a lot of research into it and how to implement it, I just grabbed something that worked in my specific situation and threw it in.

@johnbender
Copy link
Contributor

@ArakTaiRoth

I'm going to move this to a feature request and close it. We're looking to address these types of things in 1.2

https://github.com/jquery/jquery-mobile/wiki/Feature-Requests

@johnbender johnbender closed this Apr 2, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants