Skip to content
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.

Allow to define on li the data-iconpos="left". #3157

Closed
wants to merge 1 commit into from

Conversation

remidewitte
Copy link

Very useful when used with rtl languages.

@johnbender
Copy link
Contributor

@Wilto

Can you pull this into master and sort out the issues? Sample:

<ul data-role="listview" data-inset="true">
  <li>Acura</li>
  <li data-iconpos="left"><a href="debug.html">foo</a></li>
</ul>

You'll see that the icon is overlapped with the link text.

@jaspermdegroot
Copy link
Contributor

This PR won't change anything because ui-btn-icon-left will be ignored by list items, just like ui-btn-icon-right in the current situation. List items use ui-li-has-arrow and there is no icon position involved in that one.
ui-btn-icon-left is used to set applicable padding on ui-btn-inner for regular buttons, but for list items there is a rule which removes the padding from ui-btn-inner and the padding is set on the anchor element (ui-link-inherit) instead.
To make this work you would have to make a lot more changes to the JS as well as the CSS (also think about split buttons, count bubbles, etc.).

@johnbender
Copy link
Contributor

Closing based on @uGoMobi's recommendations.

@johnbender johnbender closed this May 14, 2012
@jaspermdegroot
Copy link
Contributor

FYI - I added this to the feature request wiki page

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants