Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with pandoc version on ReadTheDocs #2126

Closed
adamjstewart opened this issue Mar 20, 2024 · 3 comments · Fixed by #2128
Closed

Compatibility with pandoc version on ReadTheDocs #2126

adamjstewart opened this issue Mar 20, 2024 · 3 comments · Fixed by #2128

Comments

@adamjstewart
Copy link

The newest version of Ubuntu available on ReadTheDocs is Ubuntu 22.04, which comes with pandoc 2.9.2.1. However, nbconvert does not support this version of pandoc, resulting in the following (harmless) warning:

/home/docs/checkouts/readthedocs.org/user_builds/torchgeo/envs/1903/lib/python3.12/site-packages/nbsphinx/__init__.py:1058: RuntimeWarning: You are using an unsupported version of pandoc (2.9.2.1).
Your version must be at least (2.14.2) but less than (4.0.0).
Refer to https://pandoc.org/installing.html.
Continuing with doubts...
  nbconvert.utils.pandoc.check_pandoc_version()

It looks like the lower bound was changed in #1997, but I don't actually see any changes that require newer versions of pandoc. Is it possible to re-enable support for older versions of pandoc? At least until a newer version of pandoc becomes available on Ubuntu?

@tuncbkose @blink1073

@blink1073
Copy link
Contributor

We changed it to reflect what we are actually testing against. It could be that we are compatible with earlier versions, but I think the warning is appropriate.

@adamjstewart
Copy link
Author

Would it be possible to test against multiple versions of pandoc? In TorchGeo, we test against both the newest and oldest supported version of our dependencies.

@blink1073
Copy link
Contributor

We do test the min version explicitly, I opened #2128 to try our test suite against 2.9.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants