Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump pandoc max version #1997

Merged
merged 4 commits into from
Jun 8, 2023
Merged

bump pandoc max version #1997

merged 4 commits into from
Jun 8, 2023

Conversation

tuncbkose
Copy link
Contributor

@tuncbkose tuncbkose commented Jun 1, 2023

Closes #1996.

Changes:

  • soul package is added to the template (relevant)
    • There is an additional change relevant to this here made for lualatex, but it seems to cause additional issues. I am not sure what is the best way forward. Given that lualatex is not the default engine, I opted to not include said change.

The tests are passing and skimming through the release notes I didn't see anything concerning (though I am not the expert).

@tuncbkose tuncbkose force-pushed the pandoc3 branch 2 times, most recently from 8e0bf47 to 3186ac8 Compare June 1, 2023 09:51
@tuncbkose tuncbkose added dependencies Pull requests that update a dependency file maintenance labels Jun 1, 2023
@blink1073
Copy link
Contributor

I pushed a commit to see what happens with older pandoc. I think we'll want to download the lowest supported version in our "minimum versions" job.

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blink1073 blink1073 enabled auto-merge (squash) June 8, 2023 15:44
@blink1073 blink1073 disabled auto-merge June 8, 2023 15:49
@blink1073 blink1073 merged commit 8caeed7 into jupyter:main Jun 8, 2023
@tuncbkose tuncbkose deleted the pandoc3 branch June 8, 2023 17:04
@tuncbkose
Copy link
Contributor Author

I pushed a commit to see what happens with older pandoc. I think we'll want to download the lowest supported version in our "minimum versions" job.

That makes sense, thank you for catching it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support for pandoc > 3.0.0
2 participants