Skip to content
This repository has been archived by the owner on Dec 5, 2024. It is now read-only.

Musing on the stats endpoint #1

Open
rgbkrk opened this issue Nov 11, 2014 · 6 comments
Open

Musing on the stats endpoint #1

rgbkrk opened this issue Nov 11, 2014 · 6 comments

Comments

@rgbkrk
Copy link
Member

rgbkrk commented Nov 11, 2014

This is a dupe of jupyter/tmpnb#95, but likely belongs in both since they're using the same "spec".

I'm kind of wishing we had a beautiful front-end stats page (which could just be at stats.example.org), or we could make two endpoints on a given tmpnb server /stats for a beautiful mockup of the data and /api/stats for the raw JSON.

In addition, some things I've wanted during a deploy:

  • List version of the containers that are running
  • Some aggregated activity data (e.g. number of docker logs of individual containers)
@minrk
Copy link
Member

minrk commented Nov 11, 2014

If you want logs, I would probably put that on a separate endpoint. Adding container info makes sense, though. You don't want requesting stats to be too expensive, though.

@rgbkrk
Copy link
Member Author

rgbkrk commented Nov 11, 2014

You don't want requesting stats to be too expensive, though.

Ah, yeah. Maybe a separate API call then for health checks?

We could flip it around and either have tmpnb report up to tmpnb-redirector, or some other shared key value store (e.g. etcd).

@captainsafia
Copy link
Member

Can this be closed thanks to jupyter/tmpnb#162?

@rgbkrk
Copy link
Member Author

rgbkrk commented Sep 10, 2015

Most definitely!

@rgbkrk rgbkrk closed this as completed Sep 10, 2015
@rgbkrk
Copy link
Member Author

rgbkrk commented Sep 10, 2015

Ah, wait. No. This hasn't been implemented in the redirector.

@rgbkrk rgbkrk reopened this Sep 10, 2015
@captainsafia
Copy link
Member

OK. Let me change the issue title to clarify that.

I shall submit a PR soon.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants