-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add EFT as a payment method #910
base: main
Are you sure you want to change the base?
Conversation
Changed Files
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add videos and a description for the following payment method. Has the Backend PR been merged for this payment method?
src/Utilities/PaymentBody.res
Outdated
@@ -901,6 +901,30 @@ let pazeBody = (~completeResponse) => { | |||
] | |||
} | |||
|
|||
let eftBody = (~name) => [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check how pazeBody
is made please make it in a similar manner for better readability.
@@ -562,6 +562,13 @@ let paymentMethodsFields = [ | |||
displayName: "UPI Collect", | |||
miniIcon: None, | |||
}, | |||
{ | |||
paymentMethodName: "eft", | |||
icon: Some(icon("eft", ~size=19)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is eft icon present?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it's not present yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add Icon.
Type of Change
Description
EFT is a bank redirect payment method. This PR involves adding EFT as a payment method in the Hyperswitch SDK.
EFT accepts
ZAR
as currency.Implementation Summary
PaymentDetails.res
, defining its type, icon, and display name.PaymentMethodsRecord.res
to include EFT inpaymentMethodsFields
.PaymentModeType.res
to add EFT as apayment
type, map"eft"
to EFT, and include it indefaultOrder
for proper display sequencing.PaymentType.res
.PaymentBody.res
, temporarily setting the provider name asozow
.PaymentUtils.res
.How did you test it?
paymentData
inserver.js
file to imitatePayments - Create
call:localhost
, initiated a payment intent, and manually tested EFT by clicking the Pay Now button.Screen recoding of the test:
https://github.com/user-attachments/assets/4668f766-50f4-4700-86ac-9e5779a68794
Checklist
npm run re:build