New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expanding adds quotes around unquoted font-families #8

Open

bartveneman opened this issue May 11, 2017 · 0 comments

bartveneman commented May 11, 2017 •

edited

Loading

See the following fixture for the font shorthand:

"oblique 500 small-caps semi-expanded 20% / 2em monospace, \"Times New Roman\", Helvetica": {
  "font-size": "20%",
  "line-height": "2em",
  "font-style": "oblique",
  "font-weight": "500",
  "font-variant": "small-caps",
  "font-stretch": "semi-expanded",
  "font-family": "monospace, \"Times New Roman\", \"Helvetica\""
}

It adds quotes around Helvetica, while the original input doesn't have these quotes. I think the original values should be left as-is.

My particular issue is a tool that analyses some CSS and it reports the following lines as different font-stacks, while they are actually the same:

.selector {
  font: 11px Consolas, "Liberation Mono", Menlo, Courier, monospace;
  font-family: Consolas, "Liberation Mono", Menlo, Courier, monospace;
}

/**
 * Outputs these two font-stacks:
 * 1. "Consolas", "Liberation Mono", "Menlo", "Courier", monospace
 * 2. Consolas, "Liberation Mono", Menlo, Courier, monospace
 */

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment