Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make kbatch_url, token args optional #73

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

minrk
Copy link
Contributor

@minrk minrk commented Sep 16, 2024

These are usually called with kbatch_url=None, token=None from the cli which results in loading from config, but are required arguments. Make the optional arguments optional, so it's a bit nicer to call these from Python.

they accept None from the cli, so make the args themselves optional

so config is loaded by default when called from Python
@yuvipanda yuvipanda merged commit 7b11959 into kbatch-dev:main Sep 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants