Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add kbatch job logs #81

Merged
merged 3 commits into from
Oct 4, 2024
Merged

add kbatch job logs #81

merged 3 commits into from
Oct 4, 2024

Conversation

minrk
Copy link
Contributor

@minrk minrk commented Sep 27, 2024

allows getting logs by job name, which is usually what folks have

rather than needing to do job -> pod lookup

(draft because no tests yet)

this and #79 together closes #61 where someone is requesting logs for a job name, not a pod name. #79 makes the error more apparent, while this does what is actually expected (logs for a job)

allows getting logs by job name, which is usually what folks have

rather than needing to do job -> pod lookup
@minrk minrk marked this pull request as draft September 27, 2024 14:15
@minrk
Copy link
Contributor Author

minrk commented Sep 27, 2024

alternative to this: replace pod logs with job logs, since that's more like what folks are going to want. But maybe jobs can have more than one pod?

@minrk
Copy link
Contributor Author

minrk commented Sep 30, 2024

I don't think job logs can replace pod logs because things like cronjobs might have more than one pod associated.

@minrk minrk marked this pull request as ready for review September 30, 2024 09:58
@minrk minrk merged commit 2c71884 into kbatch-dev:main Oct 4, 2024
2 checks passed
@minrk minrk deleted the job-logs branch October 4, 2024 08:00
@yuvipanda
Copy link
Collaborator

Yes, adding this as an addition instead of replacement is the way to go!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to access kbatch pod logs?
2 participants