The countryMatches assertion is wrong when country code includes other countries/territories

[7hibault]

Expected Behavior

It should be possible to generate a file with

• IBAN FR3930003000306936293381A23 (randomly generated)
• BIC AGRIMQMX (valid BIC from this list)

This should be valid, as specified in the IBAN registry, some country codes include other countries / territories

Current Behavior

The countryMatches assertion fails and displays the following error:

country mismatch in BIC/IBA

Possible Solution and Implementation

This assertion happens in two places

• https://github.com/kewisch/sepa.js/blob/main/lib/sepa.js#L376
• https://github.com/kewisch/sepa.js/blob/main/lib/sepa.js#L553

We could extend this assertion to check for country codes that may include other countries/territories

var includedTerritoryCodes = {
  'FI': ['AX'],
  'FR': [ 'GF', 'GP', 'MQ', 'RE', 'PF', 'TF', 'YT', 'NC', 'BL', 'MF', 'PM', 'WF'],
  'GB': ['IM', 'JE', 'GG']
}
var countryIncludesOtherTerritory = Object.keys(includedTerritoryCodes).includes(this[pullFrom + 'IBAN'].substr(0, 2))
countryMatches = countryMatches || countryIncludesOtherTerritory && includedTerritoryCodes[this[pullFrom + 'IBAN'].substr(0, 2)].includes(this[pullFrom + 'BIC'].substr(4, 2))

Maybe we could also refactor IBAN and BIC into their own variables to make the code more readable.