-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for working with features #193
Comments
Thanks for the suggestion! I guess listing features was implemented some time ago, but we've removed the It seems like a useful addition to me, let's see what @killercup and @bjgill think. What is not clear is whether we should list aliased features as well, e.g. in semver's Cargo.toml $ cargo add nalgebra --features "abomonation-serialize"
Adding nalgebra v0.13.1 to dependencies
Features:
+ abomonation
+ abomonation-serialize
- arbitrary
- debug
- serde
- serde-derive
- serde-serialize Also we should follow cargo in specifying multiple features. |
Good point about the syntax for specifying multiple features. Sometimes I see optional dependencies that probably wouldn't work right if you enabled them individually. For example, My inclination is to list both the features and the optional dependencies themselves, but with some indentation to indicate how they're grouped together. (I'd make an example if I wasn't on my phone) I'd be happy to implement this. I looked at the code, and it seems fairly straightforward. |
Any update on this? So it'd be: I guess, removing features will rarely be done (would be acceptable to have to use an editor for that), so maybe the following syntax would be better: The syntax shouldn't be too verbose (not requiring writing |
Without considering default-features, this syntax is consistent with the
|
As for default-features, I think it makes sense for anyone who wants to have more complex argument lists to be in separate command. |
Back when this issue was created, it doesn't look like we supported any way of specifying features. Since then, we have added The second request I split out into #529. Since this seems resolved, going to go ahead and close this. |
I have two features I'd like to propose:
The first is the ability to specify features when adding dependencies, with a
-F
or--feature
flag that can be specified multiple times:The second is ... split into #529
The text was updated successfully, but these errors were encountered: