Add --precise flag for cargo-upgrade
#200
Conversation
Fixes killercup#177. If this flag is provided, all dependencies upgraded will be blindly upgraded to the version specified. Also, there has been substantial refactoring. The new `Manifests` and `Dependencies` structs now hold the logic for upgrade. This allows us to commonise the cases of a single upgrade and full workspace upgrade quite considerably. This should also make it fairly simple to extend to permit providing a list of packages to confine upgrades to. Also does some tidying up for the new `--precise` option. Most significantly, we now have a test for this functionality.
And an old bit of oddness that we can now get rid of
There was a problem hiding this comment.
Thank you, @bjgill!
I have 2 concerns:
- There is a little inconsistency between
cargo addandcargo upgradeflags: incargo addyou can specify versions in 2 ways:docopt@~0.9.0ordocopt --vers ~0.9.0, and withcargo upgradewe now havedocopt --precise ~0.9.0. - With
cargo upgradeyou can't specify version for each dependency individually.
Maybe we should just support docopt@~0.9.0 variant in cargo upgrade as well instead of the --precise flag?
Also, does this PR fix #201 (where do we assume crates.io is the only registry)?
|
I'll look at adding support for the No, this does not fix #201. I don't believe it makes matters any worse, though. |
|
OK - I've added support for |
There was a problem hiding this comment.
(where do we assume crates.io is the only registry)
Ah, we have crates.io url hardcoded:
Line 14 in c582f30
I agree that we should fix it in a separate PR.
Now that we support dep@vers syntax, what is the use case for --precise flag: when do you need to specify same version for multiple dependencies, maybe don't need this flag anymore?
The `dep@vers' mechanism seems likely to be more generally useful
|
I agree - I don't think we need |
src/crate_name.rs
Outdated
| semver::VersionReq::parse(version).chain_err(|| "Invalid crate version requirement")?; | ||
|
|
||
| Ok(Some(Dependency::new(name).set_version(version))) | ||
| // Ok(Some((name, version))) |
|
Thanks. I've made that clearer in the readme and help text. bors r+ |
200: Add `--precise` flag for cargo-upgrade r=bjgill a=bjgill Fixes #177. If this flag is provided, all dependencies upgraded will be blindly upgraded to the version specified. Added a test for this new feature. Also, there has been substantial refactoring. The new `Manifests` and `Dependencies` structs now hold the logic for upgrade. This allows us to commonise the cases of a single and full workspace upgrade quite considerably. EDIT: this also fixes #182 (I'll open a new issue for alternate registries)
Fixes #177. If this flag is provided, all dependencies upgraded will be blindly upgraded to the
version specified. Added a test for this new feature.
Also, there has been substantial refactoring. The new
ManifestsandDependenciesstructs nowhold the logic for upgrade. This allows us to commonise the cases of a single and full
workspace upgrade quite considerably.
EDIT: this also fixes #182 (I'll open a new issue for alternate registries)