Skip to content
This repository has been archived by the owner on Jul 23, 2024. It is now read-only.

Upgrade version of websocket #23

Closed
jimni1222 opened this issue Jul 8, 2019 · 0 comments · Fixed by #24
Closed

Upgrade version of websocket #23

jimni1222 opened this issue Jul 8, 2019 · 0 comments · Fixed by #24
Assignees
Labels
closed/fixed A fix for the issue was provided. issue/enhancement Issues for enhancement requests. open/approved The issue is confirmed as being a bug to be fixed or enhancement to be developed.

Comments

@jimni1222
Copy link
Contributor

Is your request related to a problem? Please describe.
The webSocket used in caver-js uses a version that is forked into personal github repository rather than being listed in npm.
This is causing an error in CircleCI, and will modify the dependency to use the version of the webSocket library that comes in npm.

Describe the solution you'd like
Modify the dependency to use the latest version of npm.
(https://www.npmjs.com/package/websocket)

Describe alternatives you've considered
Modify the dependency to use a version closer to the latest version of npm.

Additional context
OpenZeppelin/openzeppelin-sdk#929
web3/web3.js#2863
web3/web3.js@b27eff4

@jimni1222 jimni1222 added open/approved The issue is confirmed as being a bug to be fixed or enhancement to be developed. issue/enhancement Issues for enhancement requests. labels Jul 8, 2019
@jimni1222 jimni1222 self-assigned this Jul 8, 2019
@jimni1222 jimni1222 mentioned this issue Jul 8, 2019
9 tasks
@jimni1222 jimni1222 added the closed/fixed A fix for the issue was provided. label Jul 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
closed/fixed A fix for the issue was provided. issue/enhancement Issues for enhancement requests. open/approved The issue is confirmed as being a bug to be fixed or enhancement to be developed.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant