Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default PDF submission field cannot be turned off #371

Open
bahlgren opened this issue Oct 28, 2024 · 6 comments
Open

Default PDF submission field cannot be turned off #371

bahlgren opened this issue Oct 28, 2024 · 6 comments

Comments

@bahlgren
Copy link

We fail to turn off the default PDF submission field, that is, setting the "PDF requirement" to "No PDF allowed" isn't saved properly. It reverts to the previous setting after saving.

This is present in version a46a846 of Aug 22nd 2024. But we have other instances running the same version with the "No PDF allowed" setting that works as expected. So I'm puzzled.

@kohler
Copy link
Owner

kohler commented Feb 24, 2025

Hi @bahlgren sorry for leaving this. I don't have an explanation and I haven't heard of any problems on hotcrp.com. But advanced settings (JSON) might help debug it.

@bahlgren
Copy link
Author

bahlgren commented Feb 25, 2025

Thanks for the reply! I was also thinking that the json settings got in a strange state. Attaching the snippet that I believe is relevant, let me know if you would like to see more! One more thing, I think that the json settings have been carried over from an earlier version of hotcrp.

submission-pdf-issue-site-config.json

@bahlgren
Copy link
Author

In an instance where the default PDF is disabled, I see "condition": false for "id": "Submission" in the JSON config.

@kohler
Copy link
Owner

kohler commented Feb 26, 2025

There is nothing unusual in those settings. Things to try: (1) Set the “PDF requirement” to “PDF required”, save, and then set it again to “No PDF allowed”. Does that help? (2) Change the JSON for sf/submission to have "condition": false. Does that help?

@bahlgren
Copy link
Author

bahlgren commented Feb 27, 2025

I tried first setting "PDF required to complete submission", but that didn't help. Regardless of whether set to this or "PDF optional", choosing "No PDF allowed" results in "No changes" when pressing save, and the setting returns to what it was.

Setting "condition": false however does help, it then says "No PDF Allowed", but then this setting cannot be changed to anything else instead!

@kohler
Copy link
Owner

kohler commented Feb 27, 2025

Setting "condition": false however does help, it then says "No PDF Allowed", but then this setting cannot be changed to anything else instead!

FWIW, you should be able to change the JSON settings again.

This is annoying behavior, and I might be able to make progress if I knew your options.php or your database contents. If you are comfortable doing so, you can send me (1) the content of options.php, and (2) a database dump restricted to your settings (edit the output of php batch/backupdb.php to remove everything but Settings, or send the result of lib/runsql.sh "select * from Settings"), over email.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants