Skip to content
This repository has been archived by the owner on Dec 15, 2020. It is now read-only.

remove node-sass build container from CI build dependencies #1151

Closed
groob opened this issue Feb 2, 2017 · 0 comments · Fixed by #1197
Closed

remove node-sass build container from CI build dependencies #1151

groob opened this issue Feb 2, 2017 · 0 comments · Fixed by #1197
Assignees
@groob
Labels
Backlog Component: Development Infrastructure

Comments

@groob
Copy link
Contributor

groob commented Feb 2, 2017

Until now, we had to compile node-sass for Alpine due to sass/node-sass#1589 but the latest version of node-sass provides alpine builds in the release. That means we should be able to simplify deployment and use the trusted build.

Adding this to my backlog.
@groob groob self-assigned this Feb 2, 2017
@groob groob mentioned this issue Feb 10, 2017
Merged
zwass added a commit that referenced this issue Feb 10, 2017
@zwass
Migrate NPM to Yarn (#1197)
f406040 
- Modify `make deps` to use yarn
- Add `yarn.lock`
- Add yarn to `kolide-builder` docker image
- Remove `npm-shrinkwrap.json`
- Remove build for `node-sass` (fixes #1151)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@groob groob

Labels
Backlog Component: Development Infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate NPM to Yarn
1 participant
@groob