Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use kotlinx-datetime #43

Closed
BartArys opened this issue Aug 13, 2020 · 2 comments
Closed

Use kotlinx-datetime #43

BartArys opened this issue Aug 13, 2020 · 2 comments
Labels
0.7.0 Scheduled for 0.7.0 release on hold Something is preventing this issue from being resolved

Comments

@BartArys
Copy link
Contributor

BartArys commented Aug 13, 2020

The madlads over at Jetbrains just released another banger library that brings Java's DateTime API to kotlin-multiplatform. Since our project's only real remaining dependency on the Java stdlib is the datetime API we can use this to yeet that stuff out of there and then realize that we just imported megabytes of typealiases. It'll be grand.

Note that kotlinx-datetime does not typealias java.time. As such, we should leave the external API using java time intact, simply providing kotlin's version as an alternative, and remove java time as an internal dependency.

@Tmpod
Copy link
Contributor

Tmpod commented Aug 21, 2020

The library is still lacking a few features we use, specifically better formatters for formatting and parsing dates in ISO+Offset.

Nevertheless, I'm starting to port whatever I can to the new Instant class and so on. I'm working on 0.7.x and will soon make a WIP PR as Bart asked for in the Discord server.

@BartArys BartArys added the 0.7.0 Scheduled for 0.7.0 release label Aug 25, 2020
@BartArys BartArys added the on hold Something is preventing this issue from being resolved label Oct 15, 2020
@BartArys BartArys mentioned this issue Nov 1, 2020
7 tasks
@DRSchlaubi
Copy link
Member

DRSchlaubi commented Apr 13, 2021

There actually is a PR for Kotlin/kotlinx-datetime#56 which is their issue for this bug now: Kotlin/kotlinx-datetime#107
They also pushed kx.ser support to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.7.0 Scheduled for 0.7.0 release on hold Something is preventing this issue from being resolved
Projects
None yet
Development

No branches or pull requests

3 participants