OPT: Updated build setup and using github workflows. #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The timeexecution note is probably worth fixing, and maybe the docker line. The other two are more questions on the github action stuff. |
|
Also, it seems the jobs didn't run. |
ricardosantosalves
force-pushed
the
master
branch
from
b2b29e1 to
97a3528
Compare
kasterma
reviewed
Apr 5, 2022
.github/workflows/publish.yml
Outdated
| @@ -0,0 +1,27 @@ | |||
| name: Publish new version of timeexecution | |||
|
|
||
| on: | ||
| release: | ||
| types: [published] |
| - name: Build package | ||
| run: python -m build | ||
| - name: Publish package | ||
| uses: pypa/gh-action-pypi-publish@27b31702a0e7fc50959f5ad993c78deac1bdfc29 |
There was a problem hiding this comment.
Does it have to be a nasty commit ref? (I am guessing what it refs to)
| @@ -1,62 +1,75 @@ | |||
| # This Makefile requires the following commands to be available: | |||
| # * python3.6 | |||
| # * python3.10 | |||
| # * docker | |||
kasterma
approved these changes
Apr 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.