feat: Add accept header to HTTP requests #989
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 7.x #989 +/- ##
=============================================
- Coverage 89.85% 50.19% -39.67%
Complexity 1438 1438
=============================================
Files 140 140
Lines 4142 4150 +8
=============================================
- Hits 3722 2083 -1639
- Misses 420 2067 +1647 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently we had a POST to https://fcm.googleapis.com that failed (a 502). The response was more noisy than necessary because it was HTML. Ideally the response could be a simple JSON or plain text instead.
I am not sure if the Google API will respect the Accept header in this scenario, my experience with firebase is admittedly fairly limited, but it I don't think it hurts adding it?