Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better warning message for missing Box custom methods #68

Open
ppaulojr opened this issue Apr 16, 2018 · 1 comment
Open

Better warning message for missing Box custom methods #68

ppaulojr opened this issue Apr 16, 2018 · 1 comment

Comments

@ppaulojr
Copy link

We could modify the Assertion code to handle better cases where the developer forgot to write the code to handle the custom Box.

    SEL mappingSelector = NSSelectorFromString([NSString stringWithFormat:@"boxValueAs%@:", mappingType]);
    AssertTrueOrReturnNoBlock([self respondsToSelector:mappingSelector], ^(NSError *error) {
    });

In the AssertTrueOrReturnNoBlock we could print the expected selector.

@krzysztofzablocki
Copy link
Owner

sounds like a good improvement, would you be able to submit a PR for that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants