Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hardcoded file extension #124

Closed
cyberhck opened this issue May 15, 2024 · 1 comment
Closed

hardcoded file extension #124

cyberhck opened this issue May 15, 2024 · 1 comment

Comments

@cyberhck
Copy link
Contributor

cyberhck commented May 15, 2024

const packageUrl = `https://github.com/cli/cli/releases/download/v${version}/gh_${version}_${platform}_amd64.tar.gz`

Hello there, I'm using this action in self-hosted runners and one of the usage is to run with macOS, but this line in the action hardcodes the format to be tar.gz, whereas, github.com/cli/cli 's releases page, the archive format is zip for macos, would you be open to a PR that'll take the zip format as an input and that will default to .tar.gz so that it's not a breaking change?

@ksivamuthu
Copy link
Owner

Merged #125 and released new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants