Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs reference wrong fluentd image #1940

Open
peschmae opened this issue Feb 5, 2025 · 2 comments
Open

Docs reference wrong fluentd image #1940

peschmae opened this issue Feb 5, 2025 · 2 comments
Labels
bug Something isn't working

Comments

@peschmae
Copy link

peschmae commented Feb 5, 2025

Describe the bug:
In the release description (https://github.com/kube-logging/logging-operator/releases/tag/5.1.1 ) as well as on the docs page (https://kube-logging.dev/docs/image-versions/ ) the fluentd image is references at ghcr.io/kube-logging/fluentd but that image doesn't exist.
Additionally the image listed in the release notes is 5.1.1, but that doesn't exist either, and instead 5.1.1-full exists.

In the code the image is referenced properly, but referencing the latest image: https://github.com/kube-logging/logging-operator/blob/5.1.1/pkg/sdk/logging/api/v1beta1/logging_types.go#L210

In the docs https://kube-logging.dev/docs/image-versions/ the repository is also wrong, and additionally a different image version/tag is referenced here as well.

Expected behaviour:
The docs, release notes and the code should reference the same images

Steps to reproduce the bug:
Trying to pull the image as referenced in the release notes:

docker pull ghcr.io/kube-logging/fluentd:5.1.1

Additional context:
It would be nice, to have the used images list, as a JSON in the release, to make syncing the images to a custom mirror easier. This JSON could then also be used to generate the docs page, and maybe even the release notes. This would way, it would be less error prone.

/kind bug

@peschmae peschmae added the bug Something isn't working label Feb 5, 2025
@csatib02
Copy link
Member

csatib02 commented Feb 5, 2025

Thanks for checking!

Fixed in the release: https://github.com/kube-logging/logging-operator/releases/tag/5.1.1

@pepov
Copy link
Member

pepov commented Feb 5, 2025

The docs page has not been updated yet, it references the previous release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants