Fine tune watch selectors for less memory usage #1929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepov
force-pushed
the
watch-selectors
branch
from
2446002 to
e9f4e65
Compare
OverOrion
approved these changes
Jan 29, 2025
pepov
force-pushed
the
watch-selectors
branch
3 times, most recently
from
29c271b to
8517ed5
Compare
Signed-off-by: Peter Wilcsinszky <[email protected]>
Signed-off-by: Peter Wilcsinszky <[email protected]>
pepov
force-pushed
the
watch-selectors
branch
from
66949c8 to
d57b0ae
Compare
csatib02
approved these changes
Feb 3, 2025
Signed-off-by: Peter Wilcsinszky <[email protected]> Co-authored-by: Bence Csati <[email protected]>
Signed-off-by: Bence Csati <[email protected]>
Signed-off-by: Bence Csati <[email protected]>
csatib02
force-pushed
the
watch-selectors
branch
from
d57b0ae to
180e769
Compare
Signed-off-by: Bence Csati <[email protected]>
Signed-off-by: Bence Csati <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The point is to introduce a backwards compatible option to reduce memory usage in large environments.
The PR introduces two new operator flags:
watch-labeled-children: only watch child resources (pods, daemonsets, configmaps, etc) created by the operator with specific labels to avoid watching resources the operator is not concerned with. This option will be enabled by default in a future new minor version.watch-labeled-secrets: only watch secrets withlogging.banzaicloud.io/watch: enabledlabel. This has the risk of breaking the operator if certain secrets are not labeled correctly. This option will be enabled by default in a future new major version.Fixes: #1930 in 5f5aee0