clean-up github release asset download code in github repository client's downloadFilesFromRelease

[ykakarap]

Detailed Description:

The code to download a github release asset can be clean-up a bit.

Code:

cluster-api/cmd/clusterctl/client/repository/repository_github.go

Lines 379 to 405 in 62cd2b6

	var redirect string
	var downloadReleaseError error
	reader, redirect, downloadReleaseError = client.Repositories.DownloadReleaseAsset(context.TODO(), g.owner, g.repository, *assetID, http.DefaultClient)
	if downloadReleaseError != nil {
	retryError = g.handleGithubErr(downloadReleaseError, "failed to download file %q from %q release", *release.TagName, fileName)
	// return immediately if we are rate limited
	if _, ok := downloadReleaseError.(*github.RateLimitError); ok {
	return false, retryError
	}
	return false, nil
	}
	if redirect != "" {
	req, err := http.NewRequestWithContext(ctx, http.MethodGet, redirect, http.NoBody)
	if err != nil {
	retryError = errors.Wrapf(err, "failed to download file %q from %q release via redirect location %q: failed to create request", *release.TagName, fileName, redirect)
	return false, nil
	}
	response, err := http.DefaultClient.Do(req) //nolint:bodyclose // (NB: The reader is actually closed in a defer)
	if err != nil {
	retryError = errors.Wrapf(err, "failed to download file %q from %q release via redirect location %q", *release.TagName, fileName, redirect)
	return false, nil
	}
	reader = response.Body
	}
	retryError = nil
	return true, nil

The above pice of code has sections in it that handle the redirect result returned by client.Repositories.DownloadReleaseAsset(). According to github documentation passing a followRedirectsClient (which we already do) should take care of redirects.

This issue is to test that it is okay to drop the redirection handling logic and drop it if it is safe to do so.

Ref: #7453 (comment) for more context.

/kind cleanup
/area clusterctl
[One or more /area label. See https://github.com/kubernetes-sigs/cluster-api/labels?q=area for the list of labels]

[sbueringer]

/triage accepted

[chrischdi]

/assign