Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vendoring from addon-resizer; update Go version #7821

Open
bboreham opened this issue Feb 10, 2025 · 6 comments
Open

Remove vendoring from addon-resizer; update Go version #7821

bboreham opened this issue Feb 10, 2025 · 6 comments

Comments

@bboreham
Copy link
Contributor

Vendor dir should be removed similar to #7572.

From the Makefile, it is currently using Go 1.12.1, which is quite old and not receiving security patches.
Unwisely pulling on the thread, it also uses godep, archived in 2019.

I was going to make a PR, but the plethora of issues made me wonder. So I'm filing this issue instead to see if there is some context I'm missing.

@raywainman
Copy link
Contributor

For a variety of reasons the addon-resizer is being developed and built on the following branch: https://github.com/kubernetes/autoscaler/tree/addon-resizer-release-1.8

This branch is getting security updates.

However, we should probably follow-suit with the removal of the vendor directory here as well.

@raywainman
Copy link
Contributor

/area addon-resizer

@bboreham
Copy link
Contributor Author

Thanks, I was indeed missing that context.

@adrianmoisey
Copy link
Member

adrianmoisey commented Feb 11, 2025

For a variety of reasons the addon-resizer is being developed and built on the following branch: https://github.com/kubernetes/autoscaler/tree/addon-resizer-release-1.8

This branch is getting security updates.

However, we should probably follow-suit with the removal of the vendor directory here as well.

Any reason to not bring that development back to the default branch?

@raywainman
Copy link
Contributor

I don't know the full history here... GKE still uses the 1.8 branch which is why most of the action for Google happens there.

There was a big change as part of 2.0 that I don't believe has been adopted yet.

@adrianmoisey
Copy link
Member

Ah interesting. As per usual there's always some history to these things

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants