-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove vendoring from addon-resizer; update Go version #7821
Comments
For a variety of reasons the addon-resizer is being developed and built on the following branch: https://github.com/kubernetes/autoscaler/tree/addon-resizer-release-1.8 This branch is getting security updates. However, we should probably follow-suit with the removal of the vendor directory here as well. |
/area addon-resizer |
Thanks, I was indeed missing that context. |
Any reason to not bring that development back to the default branch? |
I don't know the full history here... GKE still uses the 1.8 branch which is why most of the action for Google happens there. There was a big change as part of 2.0 that I don't believe has been adopted yet. |
Ah interesting. As per usual there's always some history to these things |
Vendor dir should be removed similar to #7572.
From the
Makefile
, it is currently using Go 1.12.1, which is quite old and not receiving security patches.Unwisely pulling on the thread, it also uses
godep
, archived in 2019.I was going to make a PR, but the plethora of issues made me wonder. So I'm filing this issue instead to see if there is some context I'm missing.
The text was updated successfully, but these errors were encountered: