Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[manila-csi-plugin] allow podSecurityContexts to be set in controllerplugin and nodeplugin #2711

Open
xrisaD opened this issue Nov 13, 2024 · 1 comment · May be fixed by #2759
Open

[manila-csi-plugin] allow podSecurityContexts to be set in controllerplugin and nodeplugin #2711

xrisaD opened this issue Nov 13, 2024 · 1 comment · May be fixed by #2759
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@xrisaD
Copy link

xrisaD commented Nov 13, 2024

/kind feature

What happened:

Allow the pod-level security contexts to be configurable via helm values.yaml for manila-csi-plugin for both the controllerplugin and nodeplugin.

What you expected to happen:
Proposed solution would be something along the lines of the below: with a default of no securityContext set to prevent breaking changes in end user. This allows for the flexibility to specify any of the podSecurityContext options.

# values.yaml
controllerplugin:
  podSecurityContext: {}

nodeplugin:
  podSecurityContext: {}

---
# charts/manila-csi-plugin/templates/controllerplugin-statefulset.yaml
kind: StatefulSet
apiVersion: apps/v1
...
  template:
    metadata:
    spec:
     securityContext: {{ toYaml .Values.nodeplugin.podSecurityContext | nindent 8 }}
...

---
# charts/manila-csi-plugin/templates/nodeplugin-daemonset.yaml
kind: DaemonSet
apiVersion: apps/v1
...
 template:
    metadata:
    spec:
     securityContext: {{ toYaml .Values.nodeplugin.podSecurityContext | nindent 8 }}
...

How to reproduce it:
n/a

Anything else we need to know?:
n/a

Environment:

  • openstack-cloud-controller-manager(or other related binary) version:
  • OpenStack version:
  • Others:
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 13, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
3 participants