Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[manila-csi-plugin] support muilple share rules #2725

Open
moonek opened this issue Nov 20, 2024 · 2 comments · May be fixed by #2727
Open

[manila-csi-plugin] support muilple share rules #2725

moonek opened this issue Nov 20, 2024 · 2 comments · May be fixed by #2727
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@moonek
Copy link

moonek commented Nov 20, 2024

Is this a BUG REPORT or FEATURE REQUEST?:

/kind feature

What happened:

Multiple share rules cannot be registered.

What you expected to happen:

I would like to register multiple share rules separated by commas as follows.

apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
  name: csi-manila-nfs
provisioner: nfs.manila.csi.openstack.org
allowVolumeExpansion: true
parameters:
  # Manila share type
  type: default

  csi.storage.k8s.io/provisioner-secret-name: csi-manila-secrets
  csi.storage.k8s.io/provisioner-secret-namespace: default
  csi.storage.k8s.io/controller-expand-secret-name: csi-manila-secrets
  csi.storage.k8s.io/controller-expand-secret-namespace: default
  csi.storage.k8s.io/node-stage-secret-name: csi-manila-secrets
  csi.storage.k8s.io/node-stage-secret-namespace: default
  csi.storage.k8s.io/node-publish-secret-name: csi-manila-secrets
  csi.storage.k8s.io/node-publish-secret-namespace: default
  nfs-shareClient: "10.1.10.0/24,10.2.20.0/24"

How to reproduce it:

Warning  ProvisioningFailed    3s (x6 over 53s)   manila.csi.openstack.org_openstack-manila-csi-controllerplugin-0_7699907b-feed-47cb-a5be-0dd45489522b  failed to provision volume with StorageClass "csi-manila-nfs": rpc error: code = Internal desc = failed to grant access to volume pvc-4cd02bad-b321-4aa0-85ba-64f451d1ac6b: Bad request with: [POST https://xxxxx/v2/8f21cfb9acbd4b9b91f3c39542bf68a4/shares/7617dbea-dca0-4412-afd8-cbaf36283cf0/action], error message: {"badRequest": {"code": 400, "message": "Only one '/' permitted in '10.1.10.0/24,10.2.20.0/24'"}}

Anything else we need to know?:

Environment:

  • openstack-cloud-controller-manager(or other related binary) version:
  • OpenStack version:
  • Others:
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 20, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 18, 2025
@kayrus
Copy link
Contributor

kayrus commented Feb 18, 2025

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
4 participants