Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openstack-manila-csi HELM Chart version: 2.31.4 missing node ID #2768

Open
latituder opened this issue Feb 11, 2025 · 0 comments
Open

openstack-manila-csi HELM Chart version: 2.31.4 missing node ID #2768

latituder opened this issue Feb 11, 2025 · 0 comments

Comments

@latituder
Copy link

The daemonset Pod of openstack-manila-csi doesn't startup, container nfs-nodeplugin log shows:
1 main.go:111] Driver node service initialization failed: node ID is missing
this issue only happens in HELM Chart version: 2.31.4.

When compairing with version: 2.31.1, I see difference in daemonset Pod of openstack-manila-csi.
from v2.31.4, it doens't have a startup parameter node_id.

{{ toYaml $.Values.nodeplugin.registrar.resources | indent 12 }}
        - name: {{ .protocolSelector | lower }}-nodeplugin
          securityContext:
            privileged: true
            capabilities:
              add: ["SYS_ADMIN"]
            allowPrivilegeEscalation: true
          image: "{{ $.Values.csimanila.image.repository }}:{{ $.Values.csimanila.image.tag | default $.Chart.AppVersion }}"
          command: ["/bin/sh", "-c",
            '/bin/manila-csi-plugin
            -v={{ $.Values.logVerbosityLevel }}
            {{- if $.Values.csimanila.runtimeConfig.enabled }}
            --runtime-config-file=/runtimeconfig/runtimeconfig.json
            {{- end }}
            {{- if $.Values.csimanila.topologyAwarenessEnabled }}
            --with-topology
            {{- end }}
            --endpoint=$(CSI_ENDPOINT)
            --drivername=$(DRIVER_NAME)
            --share-protocol-selector=$(MANILA_SHARE_PROTO)
            --fwdendpoint=$(FWD_CSI_ENDPOINT)
            --cluster-id="{{ $.Values.csimanila.clusterID }}"'
          ]
          env:
            - name: DRIVER_NAME
              value: {{ printf "%s.%s" .protocolSelector $.Values.driverName | lower }}
            - name: CSI_ENDPOINT
              value: "unix:///var/lib/kubelet/plugins/{{ printf "%s.%s" .protocolSelector $.Values.driverName | lower }}/csi.sock"
            - name: FWD_CSI_ENDPOINT
              value: "unix://{{ .fwdNodePluginEndpoint.dir }}/{{ .fwdNodePluginEndpoint.sockFile }}"
            - name: MANILA_SHARE_PROTO
              value: "{{ .protocolSelector }}"

meanwile, in version 2.31.1, it has --nodeid=$(NODE_ID)

{{ toYaml $.Values.nodeplugin.registrar.resources | indent 12 }}
        - name: {{ .protocolSelector | lower }}-nodeplugin
          securityContext:
            privileged: true
            capabilities:
              add: ["SYS_ADMIN"]
            allowPrivilegeEscalation: true
          image: "{{ $.Values.csimanila.image.repository }}:{{ $.Values.csimanila.image.tag | default $.Chart.AppVersion }}"
          command: ["/bin/sh", "-c",
            '/bin/manila-csi-plugin
            -v={{ $.Values.logVerbosityLevel }}
            --nodeid=$(NODE_ID)
            {{- if $.Values.csimanila.runtimeConfig.enabled }}
            --runtime-config-file=/runtimeconfig/runtimeconfig.json
            {{- end }}
            {{- if $.Values.csimanila.topologyAwarenessEnabled }}
            --with-topology
            --nodeaz={{ $.Values.csimanila.nodeAZ }}
            {{- end }}
            --endpoint=$(CSI_ENDPOINT)
            --drivername=$(DRIVER_NAME)
            --share-protocol-selector=$(MANILA_SHARE_PROTO)
            --fwdendpoint=$(FWD_CSI_ENDPOINT)
            --cluster-id="{{ $.Values.csimanila.clusterID }}"'
          ]
          env:
            - name: DRIVER_NAME
              value: {{ printf "%s.%s" .protocolSelector $.Values.driverName | lower }}
            - name: NODE_ID
              valueFrom:
                fieldRef:
                  fieldPath: spec.nodeName
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant