Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear message if service exists #432

Closed
cheld opened this issue Feb 25, 2016 · 5 comments
Closed

Unclear message if service exists #432

cheld opened this issue Feb 25, 2016 · 5 comments

Comments

@cheld
Copy link
Contributor

cheld commented Feb 25, 2016

Issue details

Validation message might be confusing

Steps to reproduce

Steps:

  1. Open deploy from settings
  2. Enter test as app name
  3. Deploy
  4. Delete test, but not service
  5. Open deploy again
  6. Enter test as app name
Observed result

Validation error: "Application with this name already exists within namespace default."

However, Zerostate page is shown. So cluster seems to be empty.

Expected result

Unclear, at least message must be improved and documentation

@bryk bryk added this to the v1.0 milestone Mar 1, 2016
@bryk
Copy link
Contributor

bryk commented Mar 1, 2016

Fix should be easy. We can do this for 1.0. What do you think?

@maciaszczykm
Copy link
Member

Working on it.

@maciaszczykm
Copy link
Member

I'm thinking about solution for this. The most accurate one seems to be sending more information from backend (at the moment it's whole validation result, for replication controller and service name together). Instead of it we could send both of these information. However, it will require more changes in architecture to display correct message in UI depending on data from backend. I'm not sure if we should complicate it like this.

Second solution is really simple and it's changing validation message. How it should look like? Now it's Application with this name already exists within namespace ?. My proposition is Replication controller or service with this name already exists within namespace ?. What do you think about it? Do you have any other propositions?

@bryk
Copy link
Contributor

bryk commented Mar 7, 2016

The latter sounds good enough :) Can you send a PR? :)

@maciaszczykm
Copy link
Member

@bryk Sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants