Pod count should be trimmed

[cheld]

Issue details

leading or trailing spaces should be ignored. Similar behavior at Gmail

Steps to reproduce

1. Open deploy from settings
2. Enter "5 " as number of pods

Observed result

validation error

Expected result

ok

Comments

visually the input seems correct. So, the validation message is not understandable

[cheld]

Same for many other fields

[bryk]

I cannot reproduce on Chrome. What's your browser?

[cheld]

Sorry. I could not reproduce on Chrome either. I tested with Firefox 44 on Ubuntu

[bryk]

Closing.

[cheld]

Sorry for confusion.

• The bug is not reproducible on Chrome
• The bug IS reproducible on Firefox.

Low prio, though.

Please reopen.

[maciaszczykm]

I've done pretty much investigation in this matter and it won't be easy to fix. To be honest I think we shouldn't fix it at all, because it's Firefox bug, not ours.

Firefox doesn't fully implement <input type="number"> behaviour. It performs number validation on input field, but it doesn't filter alpha and whitespace characters. Moreover, it seems to be not only one missing thing.

I've tried to create new directive kd-numbers-only and use it everywhere to ensure, that fields will work in the same way on every browser:

export default function numbersOnlyDirective() {
  return {
    require: 'ngModel',
    link: function (scope, element, attr, ngModelCtrl) {
      function filterInputValue(inputValue) {
        if (inputValue) {
          var transformedValue = inputValue.replace(/[^0-9]/g, '');
          if (transformedValue !== inputValue) {
            ngModelCtrl.$setViewValue(transformedValue);
            ngModelCtrl.$render();
          }
          return transformedValue;
        }
        return undefined;
      }
      ngModelCtrl.$parsers.unshift(filterInputValue);
    }
  };
}

Unfortunately providing whitespaces don't execute it on Firefox, only alpha characters. Moreover to make it work there was a need to switch <input type="number"> to <input type="text">.

There are too much issues with it on Firefox, that I believe we shouldn't create big workarounds just to make it work. I'd create a bug for it and perhaps change message to warn user about possible issues (there is even specific attribute for Firefox to display custom message only for it).

CC @floreks @bryk @cheld

[floreks]

If this is an issue with firefox type="number" implementation then this should be reported in there as a bug. Forcing this directive workaround will make code less readable and soon we may end up with many workarounds for specific browsers that will complicate the code and lower its quality.

I'd only add <ng-messages> in order to display some message when required or number validation fails. That's simple and doesn't require any workarounds.

[maciaszczykm]

Adding <ng-messages> would require disabling default HTML5 validation with novalidate, and disabling OK button if validation result is false.

Other possible solution is adding x-moz-errormessage="Must be positive number". It would create custom message for Firefox browser.

Which one seems to be more suitable for you?