Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hanging Deploy App form (due to long label keys/values?) #447

Closed
olekzabl opened this issue Feb 25, 2016 · 4 comments
Closed

Hanging Deploy App form (due to long label keys/values?) #447

olekzabl opened this issue Feb 25, 2016 · 4 comments
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@olekzabl
Copy link
Contributor

Issue details

Nothing happens after clicking "Deploy" button at the bottom. (Five times in a row).

Steps to reproduce
  1. Deploy a Containerized App
  2. Select "Specify app details below"
  3. App name: olekz13 (sth not used before)
  4. Container image: gcr.io/google_containers/heapster:v0.18.4
  5. Expose service externally: Y
  6. Description: abcdefghijkl
  7. Add a label:
    • key: 199 repetitions of abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ
    • value: 165 repetitions of abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ
  8. Click "Deploy"
Observed result

Nothing happens at all. (Or I've missed something again).

Expected result

Either a warning about faulty data in the form, or a successful deployment.

Comments

After clicking "Cancel", I get back to the dashboard, in which no new app has been deployed.
(That's just reasonable, given the above behaviour).

@cheld
Copy link
Contributor

cheld commented Feb 26, 2016

Validation missing on labels and keys

@cheld
Copy link
Contributor

cheld commented Feb 26, 2016

P1

@digitalfishpond
Copy link
Contributor

looking into this now

@bryk bryk added this to the v1.0 milestone Mar 1, 2016
@bryk
Copy link
Contributor

bryk commented Mar 1, 2016

Thanks @digitalfishpond!

@floreks floreks added kind/bug Categorizes issue or PR as related to a bug. priority/P1 and removed area/frontend labels Mar 8, 2016
@bryk bryk closed this as completed Mar 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

5 participants