Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong display of icons in producion #529

Closed
taimir opened this issue Mar 14, 2016 · 4 comments · Fixed by #548
Closed

Wrong display of icons in producion #529

taimir opened this issue Mar 14, 2016 · 4 comments · Fixed by #548
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@taimir
Copy link
Contributor

taimir commented Mar 14, 2016

Issue details

Environment
Dashboard version: HEAD
Kubernetes version: HEAD
Operating system: Ubuntu 14.04 LTS
Node.js version: v4.2.3
Go version: 1.5.1
Steps to reproduce

Checkout HEAD of master branch of dashboard. If needed, run npm install to get the recent icons changes. Run gulp serve:prod to serve in production.

Observed result

The icons (e.g. in the deploy form) are not displayed correctly:

dashboard_issue

Expected result

The material design icons should be displayed correctly. The text on the screen should not overlap.

Comments

I think this was caused by 949f4c9. When I check out a previous commit (e.g. fed0c9f), there is no issue.

@taimir
Copy link
Contributor Author

taimir commented Mar 14, 2016

@maciaszczykm can you take a look? Might be a problem with my setup?

@maciaszczykm
Copy link
Member

I'm going to revert it for now.

@maciaszczykm
Copy link
Member

We need to use https://github.com/google/material-design-icons/tree/master/iconfont content and place it in our assets instead of adding new bower components like I did before.

@taimir
Copy link
Contributor Author

taimir commented Mar 14, 2016

You mean cloning into src/app/assets? I guess that would work. The alternative would be to actually move the bower_components/... icon asset files ... during the gulp assets task to the dist/assets folder, but then the relative paths won't match in development vs. production.

I think your suggestion might well be the easier / better way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants