Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect sorting some columns in PODS and EVENTS views #571

Closed
kwodzynski opened this issue Mar 24, 2016 · 3 comments
Closed

Incorrect sorting some columns in PODS and EVENTS views #571

kwodzynski opened this issue Mar 24, 2016 · 3 comments
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@kwodzynski
Copy link

Issue details

Incorrect sorting some columns in PODS and EVENTS views

Environment
Dashboard version: gcr.io/google_containers/kubernetes-dashboard-amd64:v1.0.0
Kubernetes version: v1.3.0-alpha.0.604+b494cbc0c17dd7
Operating system: linux/amd64
Node.js version: v0.10.40
Go version: go1.4.2
Steps to reproduce

I have correctly replication controler, I go to POD and EVENTS views, and I start sorting

Observed result

in POD view:

  • Columns which contains the same, or empty values are sorting by name of POD - it is OK?
  • Column "Status" also sorting by name of POD, although it contains various values
    image
    status

in EVENTS view:

  • Sorting by column "Source" returns different results every time
Expected result

Sorting by columns "Status" and "Source" should return correctly results.

Comments

What do you think about sorting by columns which contains the same, or empty values? In this case sorting by name of POD is ok?

@bryk
Copy link
Contributor

bryk commented Mar 25, 2016

Yeah, this looks bad.

@bryk bryk added kind/bug Categorizes issue or PR as related to a bug. priority/P2 labels Mar 25, 2016
@bryk
Copy link
Contributor

bryk commented Mar 25, 2016

@maciaszczykm You implemented the table. Do you know what might be wrong?

@maciaszczykm maciaszczykm self-assigned this Mar 25, 2016
@maciaszczykm
Copy link
Member

Columns which contains the same, or empty values are sorting by name of POD - it is OK?

Yes.

Column "Status" also sorting by name of POD, although it contains various values

There is a bug, someone forgot to update column ID in HTML while updating pod object members name (I'll add comments to make sure, that this mistake won't happen again). I'll create pull request for it.

Sorting by column "Source" returns different results every time.

Results seem to be same all the time in my environment, but order is not correct. I'll investigate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

3 participants