Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong field name in dual-stack networking page #49821

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

priyanshsao
Copy link

Description

This PR updates the documentation under Dual-stack options on new Services. In point 3, the last mention of .spec.clusterIPs is incorrectly referenced and should be replaced with spec.ipFamilies .

Issue

This PR resolves #49773

Closes: #49773

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 18, 2025
@k8s-ci-robot k8s-ci-robot requested a review from aramase February 18, 2025 11:45
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Feb 18, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sftim for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 18, 2025
Copy link

netlify bot commented Feb 18, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 70e0c21
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67b472e7a2e20f0008dcc8f1
😎 Deploy Preview https://deploy-preview-49821--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sftim
Copy link
Contributor

sftim commented Feb 18, 2025

/retitle Fix wrong field name in dual-stack networking page

@k8s-ci-robot k8s-ci-robot changed the title Replaced '.spec.clusterIPs' with '.spec.ipFamilies' in docs/concepts/services-networking/dual-stack.md Fix wrong field name in dual-stack networking page Feb 18, 2025
Comment on lines 150 to +151
IPv4 address in `.spec.clusterIPs`, `.spec.clusterIP` is set to the IPv6 address because that is
the first element in the `.spec.clusterIPs` array, overriding the default.
the first element in the `.spec.ipFamilies` array, overriding the default.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. I think the original text is correct. Or you could try:

Suggested change
IPv4 address in `.spec.clusterIPs`, `.spec.clusterIP` is set to the IPv6 address because that is
the first element in the `.spec.clusterIPs` array, overriding the default.
the first element in the `.spec.ipFamilies` array, overriding the default.
IPv4 address in `.spec.clusterIPs`, Kubernetes sets `.spec.clusterIP` to the IPv6 address (because the
IPv6 address comes first in the `.spec.clusterIPs` list).

@sftim
Copy link
Contributor

sftim commented Feb 18, 2025

@kubernetes/sig-network-misc does the existing page look correct?

@k8s-ci-robot k8s-ci-robot added the sig/network Categorizes an issue or PR as relevant to SIG Network. label Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language sig/network Categorizes an issue or PR as relevant to SIG Network. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potential edit for k8s.io/docs/concepts/services-networking/dual-stack/
3 participants