-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wrong field name in dual-stack networking page #49821
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Priyansh Sao <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
/retitle Fix wrong field name in dual-stack networking page |
IPv4 address in `.spec.clusterIPs`, `.spec.clusterIP` is set to the IPv6 address because that is | ||
the first element in the `.spec.clusterIPs` array, overriding the default. | ||
the first element in the `.spec.ipFamilies` array, overriding the default. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. I think the original text is correct. Or you could try:
IPv4 address in `.spec.clusterIPs`, `.spec.clusterIP` is set to the IPv6 address because that is | |
the first element in the `.spec.clusterIPs` array, overriding the default. | |
the first element in the `.spec.ipFamilies` array, overriding the default. | |
IPv4 address in `.spec.clusterIPs`, Kubernetes sets `.spec.clusterIP` to the IPv6 address (because the | |
IPv6 address comes first in the `.spec.clusterIPs` list). |
@kubernetes/sig-network-misc does the existing page look correct? |
Description
This PR updates the documentation under Dual-stack options on new Services. In point 3, the last mention of .spec.clusterIPs is incorrectly referenced and should be replaced with spec.ipFamilies .
Issue
This PR resolves #49773
Closes: #49773