address comments

lambdaclass · Jun 6, 2022 · ab1251b · ab1251b
1 parent 76aa395
commit ab1251b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/eth_client/lib/eth_client/abi.ex b/eth_client/lib/eth_client/abi.ex
@@ -15,7 +15,8 @@ defmodule EthClient.ABI do
   def get(abi_path), do: get_local(abi_path)
 
   def to_selector(function_def) do
-    ABI.FunctionSelector.decode(function_def["name"])
+    function_def["name"]
+    |> ABI.FunctionSelector.decode()
     |> Map.put(:method_id, function_def["selector"])
     |> Map.put(:state_mutability, function_def["stateMutability"])
   end
@@ -36,12 +37,9 @@ defmodule EthClient.ABI do
 
     case System.cmd("python3", [decode_path, bytecode]) do
       {hashes, 0} ->
-        {:ok, funclist} =
-          hashes
-          |> Jason.decode()
-
         funclist =
-          funclist
+          hashes
+          |> Jason.decode!()
           |> Enum.filter(fn %{"selector" => hash} -> hash != "_fallback()" end)
           |> Enum.map(&to_selector/1)
           |> Enum.map(&filter_unnamed/1)

diff --git a/eth_client/lib/eth_client/contract.ex b/eth_client/lib/eth_client/contract.ex
@@ -104,7 +104,7 @@ defmodule EthClient.Contract do
     parse_abi(tail, acc)
   end
 
-  defp build_function_by_hash(%{method_id: _selector, state_mutability: mutability} = method)
+  defp build_function_by_hash(%{state_mutability: mutability} = method)
        when mutability in ["pure", "view"] do
     args =
       method.types