Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Gulp task #13

Closed
jamesplease opened this issue Aug 8, 2015 · 0 comments
Closed

Default Gulp task #13

jamesplease opened this issue Aug 8, 2015 · 0 comments

Comments

@jamesplease
Copy link
Collaborator

The default gulp task should just run the tests, I think, and not build the lib. There are two reasons for this:

  1. Running the tests is generally more common than building the lib, as you only build when it comes release time, but each release has many individual updates which are tested.
  2. Working on Marionette we found that contributors would often run the default task when developing to run the tests. When the default task builds the library, you usually end up getting PRs where the lib has been built, which generally isn't what you want. When we changed the default task to only run the tests, we got a lot less PRs with the src code included.

If you are 👍 I will make a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants