add extra case for gitlab repo dir name #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jpetrucciani Thank you. See the review I've made. And please merge in master. |
|
I've merged master in! But I'm not currently able to see a review on here - could you link me? |
https://github.com/leg100/otf/pull/654/files/d988a1f0da0b4baeb57f3d0628dbdac285646b8b |
|
apologies if i'm missing something - when i click that link, i just see this:
|
leg100
requested changes
Dec 5, 2023
Ah sorry, my bad, my review was still in pending (I've never used this functionality before). You should see it now. |
|
@leg100 no worries! Thank you for your responsiveness! I've pushed that update |
leg100
approved these changes
Dec 5, 2023
leg100
pushed a commit
that referenced
this pull request
Dec 7, 2023
🤖 I have created a release *beep* *boop* --- ## [0.2.1](v0.2.0...v0.2.1) (2023-12-07) ### Bug Fixes * add extra case for gitlab repo dir name ([#654](#654)) ([5424565](5424565)) * organization tokens ([#660](#660)) ([be82c55](be82c55)) * various agent pool and job bugs ([#659](#659)) ([ed9b1fd](ed9b1fd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Merged
leg100
added a commit
that referenced
this pull request
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a small change we had to make for solving the issue with #651 wherein we see a different name structure for the directory within the tarball that we get from gitlab